Update language selector component with accessibility test results.

[juliasolorzano]

Fixes #3123

Preview link

[amycole501]

• On the first check under screen reader it's for [3.1.2 Language of Parts] WCAG AA (https://www.w3.org/TR/WCAG21/#language-of-parts)
• On check 2.4.6, under the bold "The language selector component may not pass all elements of this test." add "The language selector may be confusing to some users.
  We have logged this issue and are prioritizing it. Learn more about this issue on GitHub.
• On check 2.4.6 remove the redundant "The language selector may not pass all elements of this test." (The one that isn't bold.)
• On check 3.2.2 remove the redundant "The language selector may not pass all elements of this test." (The one that isn't bold.)
• On check 3.2.2 under the bold "The language selector component may not pass all elements of this test." add "Users may not expect the language of the page to change" We have logged this issue and are prioritizing it. Learn more about this issue on GitHub.
• On check 2.4.7 change "has" to "have"

[juliasolorzano]

@amycole501 all of the fixes are now live on the preview url. Please note that the The language selector may not pass all elements of this test. is hard coded into the template.

[amycole501]

• On what is now the LAST check under screen reader the check is for [3.1.2 Language of Parts] WCAG AA (https://www.w3.org/TR/WCAG21/#language-of-parts) and not "on focus"
• On check 2.4.6, under the bold "The language selector component may not pass all elements of this test." add "The language selector may be confusing to some users. We have logged this issue and are prioritizing it." .
• On check 3.2.2 under the bold "The language selector component may not pass all elements of this test." add "Users may not expect the language of the page to change. We have logged this issue and are prioritizing it."

[juliasolorzano]

@amycole501 the two GH issues have been added, per the hard coded content in the template and the update has been made to 3.1.2. It looks like that WCAG criterion had not been added to the ally test files before and needed to be directly added, see commit here.

[amycole501]

A few minor changes:

• On 2.4.6 move this sentence "The language selector may be confusing to some users." to right before "We have logged this issue and are prioritizing it". So it'll now read "The language selector may be confusing to some users. We have logged this issue and are prioritizing it."

• On 3.2.2 do the same thing. Move "Users may not expect the language of the page to change." to right before "We have logged this issue..."

• On 4.1.2 add a comma after "example". So it would read For example, “List, with eight items”.

[juliasolorzano]

• On 2.4.6 move this sentence "The language selector may be confusing to some users." to right before "We have logged this issue and are prioritizing it". So it'll now read "The language selector may be confusing to some users. We have logged this issue and are prioritizing it."
• On 3.2.2 do the same thing. Move "Users may not expect the language of the page to change." to right before "We have logged this issue..."

@amycole501 for the above two requests, the highlighted content in this screenshot is hard coded into the template and cannot be customized without effecting other page content. This would be a major change to our template structure, but let me know how you would like to proceed.

On 4.1.2 add a comma after "example". So it would read For example, “List, with eight items”.

This has been fixed and should be viewable on the preview url.

[amycole501]

How was it done on the input mask page? https://designsystem.digital.gov/components/input-mask/accessibility-tests/

[juliasolorzano]

@amycole501 ah yes! There is a customizable field that you can add that content to. It should be updated now on the the preview url.

[amycole501]

Two minor updates:

• On 2.4.6 remove the black "The language selector may be confusing to some users."
• On 3.2.2 remove the black "Users may not expect the language of the page to change."

[juliasolorzano]

@amycole501 those updates have been made are will be viewable on the preview url once the build completes for the pages build.

[amycole501]

Looks good! Thanks!

[amycole501]

@juliaelman is this blocked from passing all the tests and/or do we need another reviewer?

[heymatthenry]

Yeah it's blocked until we/I can figure out how to fix the build

…

On Tue, Apr 1, 2025 at 10:14 AM Amy Cole ***@***.***> wrote: @juliaelman <https://github.com/juliaelman> is this blocked from passing all the tests and/or do we need another reviewer? — Reply to this email directly, view it on GitHub <#3150 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAABREQMVWVVY224YWGY7ND2XKNLLAVCNFSM6AAAAABZ2UTQUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRZGUYTINBXGA> . You are receiving this because your review was requested.Message ID: ***@***.***> [image: amycole501]*amycole501* left a comment (uswds/uswds-site#3150) <#3150 (comment)> @juliaelman <https://github.com/juliaelman> is this blocked from passing all the tests and/or do we need another reviewer? — Reply to this email directly, view it on GitHub <#3150 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAABREQMVWVVY224YWGY7ND2XKNLLAVCNFSM6AAAAABZ2UTQUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRZGUYTINBXGA> . You are receiving this because your review was requested.Message ID: ***@***.***>

-- Matt Henry Engineering Lead, U.S. Web Design System

[juliasolorzano]

@amycole501 build is fixed here. Re-requesting your review so we can get this merged in 💛

[annepetersen]

LGTM. Thanks!