Add v2 release banner #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated this banner, please have a look @thisisdano. Changed this to:
|
|
I like the color, position and overall appearance. I want to tweak the text a bit and make it a little smaller on mobile, but it's close! Specific feedback incoming... |
thisisdano
reviewed
Nov 9, 2018
Co-Authored-By: saracope <sara.cope@gsa.gov>
Co-Authored-By: saracope <sara.cope@gsa.gov>
Co-Authored-By: saracope <sara.cope@gsa.gov>
saracope
changed the title
thisisdano
reviewed
Nov 13, 2018
_includes/banner-news.html
Outdated
| <div class="site-banner-news" > | ||
| <p><strong>USWDS 2.0 is coming soon.</strong> | ||
| See what’s new in Version 2.</p> | ||
| <a href="https://v2.designsystem.digital.gov" onclick="ga('send', 'event', 'Viewed 2.0 preview', 'Clicked to view 2.0 version from inside site');"><button class="usa-button usa-button-secondary-inverse">Try it now</button></a> |
There was a problem hiding this comment.
Instead of wrapping a button in an a, just give the a element the button classes: usa-button usa-button-secondary-inverse
Suggested change
| <a href="https://v2.designsystem.digital.gov" onclick="ga('send', 'event', 'Viewed 2.0 preview', 'Clicked to view 2.0 version from inside site');"><button class="usa-button usa-button-secondary-inverse">Try it now</button></a> | |
| <a href="https://v2.designsystem.digital.gov" onclick="ga('send', 'event', 'Viewed 2.0 preview', 'Clicked to view 2.0 version from inside site');" class="usa-button usa-button-secondary-inverse">Try it now</a> |
|
Couple more things to tighten this up:
Should look something like this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
Description
This change adds a news banner to the site in an effort to direct folks to the v2 doc site. It uses the .usa-alert-warning banner with custom text.
*Would like feedback specifically on using the warning banner in this way and the text for this banner @thisisdano
Additional information