New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render checked AND disabled checkbox properly #1628

Merged
merged 1 commit into from Feb 8, 2017

Conversation

Projects
None yet
3 participants
@awolfe76
Contributor

awolfe76 commented Dec 15, 2016

Render checked AND disabled checkbox properly

This allows for a checkox that is both checked and disabled to render as disabled but with the check.

Additional information

Example code:
<input type="checkbox" id="usds-checkbox" disabled checked>

Before:
before

With this PR:
after

@shawnbot

Thanks for this, @awolfe76! We're prepping our 1.0 release right now, so if this doesn't make it in right now we'll be sure to include this in the next release.

@juliaelman juliaelman merged commit 7db80cd into uswds:staging Feb 8, 2017

@awolfe76 awolfe76 deleted the awolfe76:fix-checkbox branch Sep 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment