Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility]: Adding best-practice ruleset and fix for heading-level error #2549

Merged
merged 1 commit into from Jun 19, 2018

Conversation

@1Copenut
Copy link
Contributor

1Copenut commented Jun 11, 2018

Description

Adding best-practice ruleset and exceptions to axe test script. Conversation in the USWDS public Slack channel asked about best-practice rules showing up in axe web browser plugin, but not on automated test runs. I added a runOnly object to the axe-tester.js configuration object that adds best-practice rules as defined by Deque.

I changed the first <h4>Grand Canyon</h4> to <h5>Grand Canyon</h5> to fix 2 best-practices errors calling out heading order. This felt like a better approach than trying to add an exception to the axe-tester.js, as I felt letting users know of a heading order issue was a good thing.

Deque axe-core list of rules, including best practices:
https://github.com/dequelabs/axe-core/blob/develop/doc/rule-descriptions.md

…ed heading level to fix axe best-practice error.
@maya

This comment has been minimized.

Copy link
Contributor

maya commented Jun 11, 2018

Thanks so much, @1Copenut! We'll need to review the best-practice ruleset to ensure it's what we want to run. By law, we need to ensure Section 508 and WCAG 2.0 AA are met, but of course, we can go above our requirements too. Looking at the list, cat.semantics might be something we want to add in the future as well. Stay tuned!

@maya maya self-requested a review Jun 19, 2018
@maya
maya approved these changes Jun 19, 2018
@maya maya merged commit 4dedfeb into uswds:develop Jun 19, 2018
2 of 3 checks passed
2 of 3 checks passed
ci/circleci: build Your tests failed on CircleCI
Details
codeclimate All good!
Details
security/snyk - package.json (uswds) No manifest changes detected
@maya maya changed the title [UI component]: Adding best-practice ruleset and fix for heading-level error [Accessibility]: Adding best-practice ruleset and fix for heading-level error Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.