Fix compile errors with Dart Sass #2867
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two errors and one warning in Dart Sass compile:
Fixes an error where certain numbers couldn't be looked up in the number-to-token conversion table. The product of a mathematical operations (like
(3 + 1)
) would fail in the lookup but regular numbers like (4
) would be OK. 🤷♀️ I fixed this by using strings like'4'
for keys in the lookup instead of numbers, and converting the numbers to strings in thenumber-to-value()
function.I also renamed the fn
number-to-token
for clarity.Fixes an error where colors (like
red
ortransparent
) passed into the color function messed up thestring()
function. Since raw colors like this shouldn't be passed into functions and mixins at all, I made this an explicit error and pointed the user to the documentation.I changed the code in
_banner.scss
to usecolor('transparent')
instead ofcolor(transparent)
.Rewrote some code to address the
interpolation near operators
warnings.