New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom font variable to allow overriding #2875

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
2 participants
@thisisdano
Copy link
Member

thisisdano commented Nov 9, 2018

This PR adds !default to the $theme-font-definitions variable in _settings-typography.scss, so the theme variable will override it.

Thanks @yomatters

@thisisdano thisisdano requested a review from uswds/core Nov 9, 2018

@saracope saracope merged commit 55b81d6 into release-2.0 Nov 9, 2018

10 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
federalist-staging/build The build is complete!
Details
federalist/build The build is complete!
Details
security/snyk - examples/browserify/package.json (thisisdano) No new issues
Details
security/snyk - examples/grunt/package.json (thisisdano) No new issues
Details
security/snyk - examples/gulp/package.json (thisisdano) No new issues
Details
security/snyk - examples/node-sass/package.json (thisisdano) No new issues
Details
security/snyk - examples/webpack/package.json (thisisdano) No new issues
Details
security/snyk - package.json (thisisdano) No new issues
Details
security/snyk - package.json (uswds) No manifest changes detected

@saracope saracope deleted the dw-fix-custom-font branch Nov 9, 2018

@thisisdano thisisdano referenced this pull request Nov 14, 2018

Merged

2.0.0-beta.4 #2879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment