Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom font variable to allow overriding #2875

Merged
merged 1 commit into from Nov 9, 2018
Merged

Fix custom font variable to allow overriding #2875

merged 1 commit into from Nov 9, 2018

Conversation

thisisdano
Copy link
Member

This PR adds !default to the $theme-font-definitions variable in _settings-typography.scss, so the theme variable will override it.

Thanks @yomatters

@thisisdano thisisdano requested a review from a team November 9, 2018 18:14
@saracope saracope merged commit 55b81d6 into release-2.0 Nov 9, 2018
@saracope saracope deleted the dw-fix-custom-font branch November 9, 2018 19:10
@thisisdano thisisdano mentioned this pull request Nov 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saracope saracope saracope approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thisisdano @saracope