Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Alerts: Add alert list examples and update styles. #3507

Merged
merged 6 commits into from Sep 11, 2020

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Jun 15, 2020

Preview 馃憗

Description

Attemps to resolve #3389.

  • Moved margin-bottom: 0 to the last item
  • Removed left padding from 1st level lists
  • Removed margin-top from alert lists

Additional information

Need confirmation on :

  • Should this behave like other lists or does it need special styling?
  • Do we expect users to use .usa-list in their alert lists?

This also might be a good opportunity to update alerts.

We're adding the border via a pseudoelement here.

Icon and alert body are aligned via table-cell.

There's no real example of how usa-alert--validation should look like in docs.

Do we need custom alerts?

Before you hit Submit, make sure you鈥檝e done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it鈥檚 error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

- Moved `margin-bottom: 0` to the last item
- Removed left padding from 1st level lists
- Removed margin-top from alert lists
@thisisdano thisisdano added this to the USWDS 2.8.1 milestone Jul 27, 2020
@thisisdano thisisdano removed this from the USWDS 2.8.1 milestone Aug 4, 2020
src/components/05-alerts/alerts.njk Outdated Show resolved Hide resolved
src/components/05-alerts/alerts.njk Outdated Show resolved Hide resolved
src/components/05-alerts/alerts.njk Outdated Show resolved Hide resolved
src/stylesheets/components/_alerts.scss Outdated Show resolved Hide resolved
@thisisdano thisisdano marked this pull request as ready for review September 8, 2020 18:16
@mejiaj
Copy link
Contributor Author

mejiaj commented Sep 10, 2020

Do we still need this long list example or should I simplify @thisisdano

image

@thisisdano
Copy link
Member

These long lists can and should be in some testing example, but not in the main alerts that we'd see on the website. Those should appear as they did before.

@thisisdano thisisdano merged commit 91106d6 into develop Sep 11, 2020
@thisisdano thisisdano deleted the jm-alert-lists branch September 11, 2020 18:48
@thisisdano thisisdano mentioned this pull request Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lists inside alerts are not aligned
2 participants