Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Input prefix/suffix: Ornaments for text inputs #3999

Merged
merged 14 commits into from
Mar 10, 2021

Conversation

jaredcunha
Copy link
Contributor

@jaredcunha jaredcunha commented Feb 17, 2021

Description

For issue #3939

Adds prefixes or suffixes to text fields.

Screen Shot 2021-02-17 at 9 57 16 AM

Additional information

  • Supports either icons or text
  • Creates focus state when clicking prefix/suffix (supported by usability research)

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@jaredcunha
Copy link
Contributor Author

@thisisdano do you have thoughts on what should show for the documentation site? Was thinking about using the two options above.

@thisisdano thisisdano changed the base branch from develop to uswds-2.11.0 March 1, 2021 20:50
@thisisdano thisisdano mentioned this pull request Mar 1, 2021
33 tasks
@thisisdano thisisdano merged commit b449e33 into uswds-2.11.0 Mar 10, 2021
@thisisdano thisisdano deleted the accelerator-3939/input-prefix-suffix branch March 10, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants