Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add white expand icon variant #4061

Merged
merged 5 commits into from
Mar 3, 2021
Merged

Conversation

thisisdano
Copy link
Member

@thisisdano thisisdano commented Mar 2, 2021

Adds a white version of expand_more--white.svg in usa-icons-bg to give a reversed option for projects that use a dark background in their top nav

Use with add-background-svg("usa-icons-bg/expand_more--white")

@thisisdano thisisdano requested a review from mejiaj March 2, 2021 17:38
@thisisdano thisisdano changed the title Add white expand icon for dark bgs Add white expand icon variant Mar 2, 2021
@mejiaj
Copy link
Contributor

mejiaj commented Mar 2, 2021

@thisisdano should we add the +/- for mobile menu on dark backgrounds too?

@thisisdano
Copy link
Member Author

Yup — added the plus, and I'll add the minus too

Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge after adding remove--white.svg.

@thisisdano thisisdano merged commit aead326 into develop Mar 3, 2021
@thisisdano thisisdano deleted the dw-add-white-icon-variant branch March 3, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: Icons Type: Enhancement An improvement to existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants