Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS - Layouts: Add Spanish 404 variant. #4186

Merged
merged 31 commits into from
May 24, 2021
Merged

USWDS - Layouts: Add Spanish 404 variant. #4186

merged 31 commits into from
May 24, 2021

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented May 3, 2021 •
edited
Loading

Description

Part of #4009. Creates spanish variant for 404 page template.

Preview

Code preview →
Site preview →

Additional information

  • Added a spanish base template
  • Moved error related code to it's own folder

Related PRs

Spanish 404 docs

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

mejiaj added 3 commits May 3, 2021 14:40
@mejiaj
Create Spanish base template.
8e0044c
@mejiaj
Create Spanish 404 variant.
2d1ab75 
- Move all error files to their own directory
- Templatize and hide error-inner
- Add Spanish variant
@mejiaj
Uncomment support text.
d4f8fd9
@mejiaj mejiaj marked this pull request as ready for review May 3, 2021 20:13
mejiaj added 25 commits May 4, 2021 09:04
@mejiaj
Site title: cleanup logo link attrs and add variable for menu button.
0434d1d
@mejiaj
Templatize footer component.
927c62b
@mejiaj
Footer: update primary and secondary link text.
0e4bb9f
@mejiaj
Header: fix markup displaying in site title.
0c84e97
@mejiaj
Header: add aria label variable to template.
302c32f
@mejiaj
Escape site title variable.
9a69208
@mejiaj
Move navigation variants into their own folders.
009e72b
@mejiaj
Primary nav: separate megamenu markup and create primaryLink macro.
6724a11
@mejiaj
Add Spanish title variant.
26268cc
@mejiaj
Search: cleanup templates.
ac7b7e4 
- Replace `search--header` template in favor of something more standard and reusable
- Move `search_js` var to config
- Create `search_header` var to remove section wrapper from search in header
- Move search attributes to a single object
@mejiaj
Create Spanish secondary nav.
825c2eb
@mejiaj
Create Spanish nav variation.
bec6aa9
@mejiaj
Add Spanish header variations.
f6aec9e
@mejiaj
Update base spanish template.
938ee93
@mejiaj
Add id_prefix if it exists to search input modifier.
2dd162d
@mejiaj
Navigation: set default language and pass search prefix for a11y.
3ad17dc
@mejiaj
Banner: add aria label var to banner.
7d97c50
@mejiaj
Title: remove aria label and only set Menu text in Spanish.
f7fa83b
@mejiaj
Footer: update placeholder content and create contact object.
56b8ba7
@mejiaj
Identifier: add brackets to identifier domain.
a72de62
@mejiaj
Error page: add spanish return to top link in footer.
a4cbeac
@mejiaj
Primary nav updates.
49e5718 
- Add close label variable
- Update placeholder text
- Only set close label in Spanish
@mejiaj
Secondary nav: update placeholder text.
8a7ee5c
@mejiaj
Error page: update agency example link.
74474ad
@mejiaj
Error page: update placeholder phone number.
9c59fa9
@mejiaj mejiaj mentioned this pull request May 10, 2021
Merged
4 tasks
@mejiaj mejiaj requested review from thisisdano and afeijoo May 10, 2021 17:58
thisisdano
thisisdano approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@thisisdano thisisdano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of work. Great job seeing this through.

@thisisdano thisisdano merged commit f75505a into develop May 24, 2021
@thisisdano thisisdano deleted the jm-404-lang-es branch May 24, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisdano thisisdano thisisdano approved these changes

@afeijoo afeijoo Awaiting requested review from afeijoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mejiaj @thisisdano