Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Layouts: Add Spanish authentication variants. #4213

Merged
merged 14 commits into from
Jun 4, 2021

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Jun 1, 2021

Description

Closes #4012. Creates Spanish variants for Create Account, Sign in (default), Sign in (multiple) page layouts.

Preview

Additional information

  • Resolved some ESLint issues in fractal.config.js
  • Create empty header template
  • Create password component
  • Add variables for sign-in form
  • Reorganize sign-in and create account templates

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@mejiaj mejiaj marked this pull request as ready for review June 1, 2021 20:08
@mejiaj mejiaj requested a review from afeijoo June 2, 2021 13:14
Copy link
Contributor

@afeijoo afeijoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mejiaj mejiaj requested a review from thisisdano June 3, 2021 15:04
@thisisdano thisisdano merged commit cdc072d into develop Jun 4, 2021
@thisisdano thisisdano deleted the jm-login-page-lang-es branch June 4, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Spanish version of Authentication templates
3 participants