Skip to content

USWDS: Breadcrumb - Changes negative margin from shorthand to left/right #4248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

mahoneycm
Copy link
Contributor

Resolves #4240

Description

Uses @mejiaj 's solution to fix negative margin overlap error by changing margin: units($theme-focus-width) * -1; to

margin-left: units($theme-focus-width) * -1;
margin-right: units($theme-focus-width) * -1;

Additional information

Before

image

After

image

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • [ x ] Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • [ x ] Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • [ x ] Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@thisisdano thisisdano merged commit 2fb9d52 into uswds:develop Jul 22, 2021
@thisisdano thisisdano mentioned this pull request Aug 18, 2021
@mahoneycm mahoneycm deleted the cm-neg-bc-margin branch January 14, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default negative margin on the Breadcrumb component causes overlap
3 participants