Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Combobox: add aria-controls for 508 compliance #4483

Merged
merged 4 commits into from
Feb 15, 2022

Conversation

amyleadem
Copy link
Contributor

Update the combobox input aria attributes to include aria-controls.

Addresses issue #1359 for uswds-site

This addition aligns with the Aria 1.1 combobox recommendations

@amyleadem amyleadem marked this pull request as draft January 27, 2022 17:32
@amyleadem amyleadem requested a review from mejiaj January 27, 2022 18:05
@amyleadem
Copy link
Contributor Author

@mejiaj
Please see related comments from submitter: uswds/uswds-site#1359

@amyleadem amyleadem marked this pull request as ready for review January 31, 2022 15:31
@thisisdano thisisdano merged commit 30fab63 into develop Feb 15, 2022
@thisisdano thisisdano deleted the al-combobox-508 branch February 15, 2022 22:10
@thisisdano thisisdano mentioned this pull request Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants