Icon: Remove inline style in GitHub icon to fix CSP error #4487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request seeks to resolve an error which can occur when using the USWDS Icon component SVG sprite in combination with a Content Security Policy (CSP), where the presence of an inline style tag within the GitHub icon can violate most common CSPs which do not include the
unsafe-inlinestyle-srcdirective.Additional information
The process for resolving this was to simply drop the SVG markup into the SVGOMG online SVGO optimizer tool. The produced output minified the markup and inlined the
fill-ruleas an HTML attribute.An alternative solution could be to simply remove the style tag (and accompanying
classattribute) and instead add the equivalentfill-rule="evenodd"attribute to the<path>element.Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.