Time Picker: Preserve initial input value in Time Picker component

[aduth]

Partially addresses #4331

Description

This pull request resolves an issue where if an enhanced Time Picker input has a value, the value is discarded during initialization, thereby preventing a developer from including an initial value for a time picker element.

Additional information

Note that the Fractal component variant was based on a similar Date Picker default value variant, but in that case the default value is expected to be assigned using a data-default-value attribute. Here, I chose instead to let the native value attribute be used since it is likely to be more intuitively understood as a way to control the input value, though I am open to revising this to data-default-value for consistency's sake. Edit: Per feedback, changed to data-default-value in 731748f.

---

Before you hit Submit, make sure you’ve done whichever of these applies to you:

• Follow the 18F Front End Coding Style Guide and Accessibility Guide.
• Run npm test and make sure the tests for the files you have changed have passed.
• Run your code through HTML_CodeSniffer and make sure it’s error free.
• Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

[mejiaj]

This looks good! I'm leaning towards using data-default-value for consistency. What do you think @thisisdano?

[thisisdano]

I'm sorry, this one got past me. I agree with James, let's use data-default-value here. We will need a docs update to the Time Picker component to complete this task.

[aduth]

Updated to use data-default-value in 731748f.

We will need a docs update to the Time Picker component to complete this task.

Is there anything you need from me to help push this along? In the meantime, I'll remove the "Fixes" auto-close text from the original comment.

[mejiaj]

Hey @aduth, thanks for the reminder! Nothing wrong with the functionality, it works well. Just two outstanding issues.

The guidance on Time picker under the Initialization properties the defaults are set on the usa-time-picker element, not the input inside.

Based on that we have these outstanding tasks:

• Decide if data-default-value be set on usa-time-picker or the input inside (like it currently is in PR). Any preference @thisisdano?
• Add new settings to docs in time-picker.md

https://github.com/uswds/uswds-site/blob/a4fa3a8bad7706c5e6ac6cf5cf4342d37c36f46d/_components/time-picker/time-picker.md?plain=1#L13-L23

[thisisdano]

@aduth Sorry for the backtracking, but after reviewing this issue again, we'd like to revert to your initial implementation, using the value attribute on the input. In this instance, respecting native properties and enabling progressive enhancement are more important than consistency between components.

@mejiaj Let's also work to update components like Date Picker to work more like this.

[aduth]

Sounds good, pushed the revert in fc6df77.

I still need to find some time to circle back on the documentation to wrap this up.