USWDS - Button: Add type attribute

[amyleadem]

Summary

Added type="button" to all non-form buttons to prevent default submit behaviors. This allowed us to remove preventDefault() from the relevant component JS.

⚠️ This is a potentially breaking change. Teams should update all non-form buttons to include type="button" in their markup. <button> elements that do not receive a defined type attribute will inherit type="submit" behaviors by default. This can cause unintended and undesired behavior in our buttons. Resource: Details on button types (Mozilla)

This affects these dependent or related packages:

• usa-accordion
• usa-banner
• usa-card
• usa-header
• usa-navbar
• usa-modal
• usa-nav
• usa-sidenav

Description

Closes: #3563

Problem

<button> elements that do not receive a defined type attribute will inherit type="submit" behaviors by default. This can cause unintended and undesired behavior in our buttons. Resource: Details on button types (Mozilla) ➡️

Solution

⚠️ Added type="button" to all non-form buttons to prevent default submit behaviors. This allowed us to remove preventDefault() from relevant component JS.

Tasks

• Update <button> elements in our templates to include type attribute
• Remove preventDefault where necessary in our JavaScript
• Update docs for button component to include guidance for type attribute
  • Related PR: USWDS-Site: Button: add instructions for type attribute uswds-site#1608

Additional information

Before you hit Submit, make sure you’ve done whichever of these applies to you:

• Follow the 18F Front End Coding Style Guide and Accessibility Guide.
• Run npm test and make sure the tests for the files you have changed have passed.
• Run your code through HTML_CodeSniffer and make sure it’s error free.
• Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

[thisisdano]

This looks good, but I'm going to HOLD it for right now until I can understand whether we should consider this a "breaking" change