Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite navigate_far icons to allow customColor #4780

Merged
merged 4 commits into from
Jun 8, 2022
Merged

Rewrite navigate_far icons to allow customColor #4780

merged 4 commits into from
Jun 8, 2022

Conversation

thisisdano
Copy link
Member

@thisisdano thisisdano commented Jun 7, 2022 •
edited
Loading

This PR rewrites the navigate_far_before and navigate_far_next icons to remove their custom fill and match other icons in the set that allow a customColor fill.

How to check

  1. Open the icon component page in Storybook
  2. With the web inspector, find the fill property on .usa-icon and set a custom color like red
  3. Check that navigate_far_before and navigate_far_next are red

Fixes #4752

@thisisdano thisisdano requested a review from amyleadem June 7, 2022 18:53
@thisisdano thisisdano marked this pull request as draft June 7, 2022 19:05
@thisisdano
Copy link
Member Author

Hold for a sec. This still isn't working

@thisisdano
Copy link
Member Author

OK, working now!

@thisisdano thisisdano marked this pull request as ready for review June 8, 2022 20:25
mejiaj
mejiaj approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that note on how to test, looks good!

amyleadem
amyleadem approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thisisdano thisisdano merged commit 15964b4 into develop Jun 8, 2022
@thisisdano thisisdano deleted the dw-icons-currentColor branch June 8, 2022 23:26
@thisisdano thisisdano mentioned this pull request Jun 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyleadem amyleadem amyleadem approved these changes

@mejiaj mejiaj mejiaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

USWDS - Sprite: CSS control issues for navigate_far icons
3 participants
@thisisdano @mejiaj @amyleadem