USWDS - Button group: align unstyled buttons #4812
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #4327
Preview link: Button group stories
Problem
When used inside a button group component, the unstyled button type aligns at the top of the group element.
Before:
Solution
Because the button group is built with flexbox, we can center the button's vertical alignment. This should consistently produce the desired alignment inside button groups.
After:
Testing
usa-button-group
html with the sample markup below.Bar
buttonIt is also worth thinking through if centered vertical alignment would cause unintended ill-effects.
Additional information
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm test
and make sure the tests for the files you have changed have passed.