[IDP] Language selector component #4937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes and more improvements
…ge selector dropdown
…English languages
…t ref to uswds working branch
…semantic text for screen readers
…cate English translation
21 tasks
21 tasks
thisisdano
changed the title
|
@mitchmoccia When the languages button has its menu active, selecting the button again should dismiss the menu. As far as I can tell, it does not. |
…e button is selected repeatedly
@thisisdano This has been addressed. The language selector drop down now toggles when you select the language button over and over. Tested on all examples (three or more, header example, and unstyled) and also with the keyboard. |
thisisdano
reviewed
Nov 7, 2022
packages/usa-header/_index.scss
Outdated
Comment on lines
4
to
5
| @forward "usa-skipnav"; | ||
| @forward "usa-search"; |
There was a problem hiding this comment.
@thisisdano I show those as having been removed 8 months ago with the commit message "Add dependencies to component packages"
amyleadem
reviewed
Nov 8, 2022
...a-language-selector/src/usa-language-selector--unstyled/usa-language-selector--unstyled.twig
Outdated
Show resolved
Hide resolved
thisisdano
approved these changes
Nov 8, 2022
This was referenced Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version one of the language selector component.