Skip to content

[IDP] Language selector component - #4937

Merged
thisisdano merged 50 commits into
idp-stagingfrom
mm-language-selector
Nov 8, 2022
Merged

[IDP] Language selector component#4937
thisisdano merged 50 commits into
idp-stagingfrom
mm-language-selector

Conversation

@mitchmoccia

Copy link
Copy Markdown
Contributor

Version one of the language selector component.

@thisisdano thisisdano mentioned this pull request Oct 11, 2022
21 tasks
@thisisdano thisisdano linked an issue Oct 11, 2022 that may be closed by this pull request
21 tasks
@thisisdano thisisdano changed the title Inclusive patterns language selector component [IDP] Language selector component Nov 2, 2022
@thisisdano
thisisdano changed the base branch from develop to idp-staging November 2, 2022 05:15
@thisisdano

Copy link
Copy Markdown
Contributor

@mitchmoccia When the languages button has its menu active, selecting the button again should dismiss the menu. As far as I can tell, it does not.

@mitchmoccia

Copy link
Copy Markdown
Contributor Author

@mitchmoccia When the languages button has its menu active, selecting the button again should dismiss the menu. As far as I can tell, it does not.

@thisisdano This has been addressed. The language selector drop down now toggles when you select the language button over and over. Tested on all examples (three or more, header example, and unstyled) and also with the keyboard.

Comment on lines -4 to -5
@forward "usa-skipnav";
@forward "usa-search";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove these?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thisisdano I show those as having been removed 8 months ago with the commit message "Add dependencies to component packages"

image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to restore them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create language selector component

3 participants