Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Identifier: Use valid element for identity's aria label #4964

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Sep 27, 2022

Description

Use valid element for Identifier identity aria label. Accessibility error from invalid attribute on div is now fixed. Closes #4952.

Additional information

Alternative was to use role="complementary", but that could cause additional a11y issues with user's websites.

There should be no regression in component.

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@mejiaj mejiaj marked this pull request as ready for review October 11, 2022 14:12
@mejiaj mejiaj requested a review from thisisdano October 11, 2022 14:12
@thisisdano thisisdano merged commit d237e46 into develop Oct 11, 2022
@thisisdano thisisdano deleted the jm-a11y-identifier branch October 11, 2022 19:41
This was referenced Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USWDS - Bug: Update identifier component markup for improved accessibility
2 participants