USWDS - Identifier: Use valid element for identity's aria label#4964
Merged
thisisdano merged 1 commit intodevelopfrom Oct 11, 2022
Merged
USWDS - Identifier: Use valid element for identity's aria label#4964thisisdano merged 1 commit intodevelopfrom
thisisdano merged 1 commit intodevelopfrom
Conversation
thisisdano
approved these changes
Oct 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use valid element for Identifier identity aria label. Accessibility error from invalid attribute on div is now fixed. Closes #4952.
Additional information
Alternative was to use
role="complementary", but that could cause additional a11y issues with user's websites.There should be no regression in component.
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.