Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Remove unnecessary single quote in sortable table aria-labels #5280

Merged
merged 2 commits into from
May 19, 2023

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented May 12, 2023

Summary

Fixed a typo in the sortable table JavaScript that caused the aria-label in table headers to have an unnecessary single quote.

This PR also includes fixes for a couple lintSass errors. (A couple of files just needed to have some extra spaces removed.)

Breaking change

This is not a breaking change.

Related issue

Closes #5261

Related pull requests

Changelog entry: uswds/uswds-site#2098

Preview link

Preview link: Sortable table component

Problem statement

Due to a typo, the index.js script creates an aria-label with an unncessary single quote in sortable table headers.

Solution

Removed the single quote from the index.js script.

Testing and review

Confirm that the aria labels for sortable table headers have no single quote after the header name.

For example, the table header for the first column in the first example should have

aria-label="Name, sortable column, currently unsorted"

instead of the previous:

aria-label="Name', sortable column, currently unsorted"

@amyleadem amyleadem marked this pull request as ready for review May 12, 2023 15:32
@amyleadem amyleadem requested review from mejiaj and removed request for mejiaj May 12, 2023 15:34
@amyleadem amyleadem changed the title Remove unnecessary single quote from th aria-label USWDS - Remove unnecessary single quote in sortable table aria-labels May 12, 2023
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

  • Confirmed existence of '
  • Confirmed extinction of '

Thanks Amy 🦖

@amyleadem amyleadem requested a review from thisisdano May 12, 2023 16:34
@thisisdano thisisdano merged commit 0f42460 into develop May 19, 2023
@thisisdano thisisdano deleted the al-table-extra-quote branch May 19, 2023 22:37
@thisisdano thisisdano mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USWDS - Table: Remove extra quote in caption
4 participants