-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS - Remove id from site title #5319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I tested:
- Output HTML from
npm run build:html - StorybookJS components (headers, site title, and nav partial).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
- Confirmed ID has been removed
- Confirmed correct title is displaying in storybook as well as html templates after
build:html - Confirmed USWDS is not referencing the ID in any existing code.
|
@thisisdano This PR was originally intended to be merged into #5311 so it does not have its own issue. #5311 has already been merged into |
Summary
site_titlecontent during the HTML build process. The site title appeared with the accurate value in Storybook, but showed the defaultHomevalue in the html files.idattribute from theusa-logoelement. Thisidrequired maintenance of multiple lines of JSON but did not seem to serve a clear purpose.Related PR
This was originally intended to be merged into #5311.
Preview link
Related PR
Changelog PR: uswds/uswds-site#2124
Testing and review
<Project title>for both Storybook and the following files inhtml-templates: