USWDS - Banner: Align building shape to center of icon #5370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Thanks for submitting this PR. I have added a few core team members as reviewers. We will let you know if we have any questions. |
mahoneycm
approved these changes
Jul 19, 2023
amyleadem
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
This looks good to me. Confirmed with the design team that the element is centered inside the circle.
For reference, I layered the two logos, with the old version in red and the new version in blue. It shows that the element has shifted slightly to the right.
This was referenced Sep 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improved horizontal alignment in
icon-dot-gov.svg.Breaking change
This is not a breaking change.
Related issue
Closes #5352
Related PR
Changelog PR