-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS - Utilities: Add "full-percent" palettes to top, left, right #5633
Conversation
|
@amyleadem two questions;
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm!
- Pattern matches
bottom-fullwhich previously worked - Correctly adds
top,left, andrightrelative positioning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple and effective
Summary
Fixed a bug that prevented the CSS from generating
.left-full,.right-full, and.top-fullutility classes.Breaking change
This is not a breaking change.
Related issue
Closes #5632
Related pull requests
Changelog PR
Problem statement
Our documentation for
.left-,.right-, and.top-utility classes state that USWDS offers.left-full,.right-full, and.top-fullclasses. However, these do not appear in the default USWDS CSS. USWDS CSS does currently provide a.bottom-fullclass.Solution
Added "full-percent" palettes to
.top-,.left-,.right-utility classes.Testing and review
.left-full,.right-full, and.top-fullclasses..left-full,.right-full, and.top-fullclasses.