Skip to content

Conversation

@amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Apr 26, 2024

Summary

Updated the USA.gov link in Spanish versions of the identifier. The link text now reads "Visite USAGov en Español" and the link url is now "https://www.usa.gov/es/".

Details

  • Updated the "Visite USA.gov en Español" link text to "Visite USAGov en Español".
  • Updated the url in the link to the Spanish usa.gov website. The link previously pointed to https://www.usa.gov/espanol/, but now points to https://www.usa.gov/es/.

Breaking change

This is a content and markup change for the component. It is not a breaking change, but is important to update.

Related issue

Closes #5853

Related pull requests

Changelog PR

Preview link

Problem statement

The Spanish version of the identifier component needs to be updated to reflect the following changes:

Solution

  1. Replaced the url on Spanish versions of the component. The link previously pointed to https://www.usa.gov/espanol/, but now points to https://www.usa.gov/es/.
  2. Updated the text ""Visite USA.gov en Español" to "Visite USAGov en Español" .

Testing and review

  • Confirm the link text and url have been updated on Spanish variants of the component.
  • Confirm there are no remaining references to "Visite USA.gov en Español" or "https://www.usa.gov/espanol/".

@amyleadem amyleadem added this to the uswds 3.9.0 milestone Apr 26, 2024
@amyleadem amyleadem self-assigned this Apr 26, 2024
@amyleadem amyleadem marked this pull request as ready for review April 26, 2024 18:14
@amyleadem amyleadem requested review from mahoneycm and mejiaj April 26, 2024 18:15
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@amyleadem amyleadem requested a review from thisisdano April 29, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

USWDS - Bug: Incorrect text in Spanish language versions of the identifier component

5 participants