Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tlmのpakcet handler でルーティングが終わったら,それ以外のdest flag を下ろすべき #557

Closed
Tracked by #514
meltingrabbit opened this issue Apr 27, 2023 · 0 comments
Assignees
Labels
priority::high priorityg high
Projects

Comments

@meltingrabbit
Copy link
Collaborator

概要

Tlmのpakcet handler でルーティングが終わったら,それ以外のdest flag を下ろすべき

詳細

  • ここ
    • PH_ACK PH_analyze_tlm_packet(const CommonTlmPacket* packet)
      {
      ctp_dest_flags_t flags;
      if (!CTP_is_valid_packet(packet)) return PH_ACK_UNKNOWN; // FIXME: 返り値変えたい
      flags = CTP_get_dest_flags(packet);
      // FIXME: flag の match は関数化したい
      // Housekeeping Telemetry
      if (flags & CTP_DEST_FLAG_HK) PH_add_ms_tlm_(packet); // hk_tlm のフラグが立っていても,MS_TLMとして処理する方針にした
      // Mission Telemetry
      if (flags & CTP_DEST_FLAG_MS) PH_add_ms_tlm_(packet);
      #ifdef DR_ENABLE
      // Stored Telemetry
      if (flags & CTP_DEST_FLAG_ST) PH_add_st_tlm_(packet);
      // Replay Telemetry
      if (flags & CTP_DEST_FLAG_RP) PH_add_rp_tlm_(packet);
      #endif
      // [TODO] 要検討:各Queue毎の登録エラー判定は未実装
      return PH_ACK_SUCCESS;
      }
  • HK tlm と MIS tlm が同時に立っていたとき,配送されたあとも2つたってるのはおかしい

close条件

できたら

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority::high priorityg high
Projects
No open projects
C2A
Done
Development

No branches or pull requests

1 participant