Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior of ut.expect(closed_cursor) #548

Closed
jgebal opened this Issue Jan 4, 2018 · 4 comments

Comments

4 participants
@jgebal
Copy link
Member

jgebal commented Jan 4, 2018

Currently, when ut.expect is executed with a cursor that was closed, no exception is thrown.

I think we should change that behavior as such cursor is invalid and cannot be processed.

I would prefer the call to `ut.expect(closed_cursor) to raise exception.
We do not hide exceptions raised while fetching from cursor (like divisor_equal_to_zero) so I suppose we should not hide that we cannot execute expectation on a closed cursor.

Any thoughts on this? Should we change that behavior?

@pesse

This comment has been minimized.

Copy link
Member

pesse commented Jan 12, 2018

I strongly agree with changing the behaviour. The current behaviour will probably lead to non-working tests without notifying - in my opinion worst case scenario cause it creates false confidence.

@Pazus

This comment has been minimized.

Copy link
Member

Pazus commented Jan 12, 2018

I agree, @jgebal

@AlexisGaldamez

This comment has been minimized.

Copy link
Contributor

AlexisGaldamez commented Jan 12, 2018

I'll make the change, when a cursor already closed is passed, It must throws a exception invalid refcursor, This message is okay?

@jgebal

This comment has been minimized.

Copy link
Member Author

jgebal commented Jan 13, 2018

How about: cursor is not open

@jgebal jgebal added this to the v3.0.5 milestone Jan 14, 2018

@jgebal jgebal closed this in #556 Jan 16, 2018

@jgebal jgebal modified the milestones: v3.0.5, v3.1.0 Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.