Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sonar configuration to use branches #708

Closed
jgebal opened this issue Jul 10, 2018 · 5 comments
Closed

Update sonar configuration to use branches #708

jgebal opened this issue Jul 10, 2018 · 5 comments

Comments

@jgebal
Copy link
Member

@jgebal jgebal commented Jul 10, 2018

sonarcloud.io supports multi-branch projects as well as PR notifications for quite some time now.
It would be great to update our project configuration to take benefit from new features of sonar.

If someone wants to take action on this, I can grant access to sonarcloud.io project for utPLSQL.

@lwasylow
Copy link
Member

@lwasylow lwasylow commented Jul 10, 2018

Do we want to run sonar on every branch created like feature etc, or only in PR into develop?

@jgebal
Copy link
Member Author

@jgebal jgebal commented Jul 10, 2018

It shouldn't cost anything.
We already run coveralls on every feature branch and it giver pretty cool overview :)
https://coveralls.io/github/utPLSQL/utPLSQL

@lwasylow
Copy link
Member

@lwasylow lwasylow commented Jul 10, 2018

You got my interest, I will have a read about these features, can be handy to know anyway.

@lwasylow
Copy link
Member

@lwasylow lwasylow commented Jul 11, 2018

Sounds like all is coming to update when to run analysis and tokenize a sonar properties to allow for dynamic branch/pr key.
Should be fairly simple to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants