Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move validation of throws annotation parameters to ut_executable_test #721

Closed
jgebal opened this issue Jul 17, 2018 · 0 comments · Fixed by #1038
Closed

Move validation of throws annotation parameters to ut_executable_test #721

jgebal opened this issue Jul 17, 2018 · 0 comments · Fixed by #1038
Assignees
Milestone

Comments

@jgebal
Copy link
Member

jgebal commented Jul 17, 2018

Currently, parameters of throws are validated when suite is built.
We should postpone the validation to runtime. That way, the anntation becomes truly dynamic as the package referenced by annotation parameter may not exist or may be invalid when suite is built (can be created dynamically).

This also seems like a better separation of responsibilities, as it is ut_executable_test that knows how to understand the text of annotation parameter rather than the ut_suite_builder.
This way suite building will not be carrying that responsibility anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants