Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation REGEXP problem with NLS CANADIAN FRENCH #844

Closed
caronD opened this Issue Mar 1, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@caronD
Copy link

caronD commented Mar 1, 2019

When using ut.run(); using the last release i've got this error :

Warnings:

  1. test_between_string
    Unsupported annotation "--%test(returns substring from start position to end position)". Annotation ignored.
    at "FOD.TEST_BETWEEN_STRING.NORMAL_CASE;", line 5

I'm using Oracle Database 12c Enterprise Edition Release 12.1.0.2.0 - 64bit Production, my NLS is CANADIAN FRENCH

@caronD caronD changed the title Annotations REGEXP problem with NLS CANADIAN FRENCH Annotation REGEXP problem with NLS CANADIAN FRENCH Mar 1, 2019

@jgebal jgebal added the bug label Mar 1, 2019

@jgebal jgebal self-assigned this Mar 1, 2019

@jgebal jgebal added this to the v3.1.4 milestone Mar 1, 2019

@jgebal

This comment has been minimized.

Copy link
Member

jgebal commented Mar 1, 2019

From our conversation on SLACK.

The issue is related to regexp_substr syntax in ut_annotation_parser

We use named-parameter modifier which is not part of oracle-documentaion.
We should be using: match_param or in fact remove it, as the regexp itself is doing a case-insensitive search.

I've confirmed with @caronD that the issue is resolved after removing the modifier=>'i'.

Need to create a test case to prove and document the bug before fixing it

jgebal added a commit that referenced this issue Mar 4, 2019

Fixed annotations on CANADIAN FRENCH NLS settings
Fixed issue with `modifier => 'i'` causing strange behavior when parsing annotations on `CANADIAN FRENCH` `NLS` settings.

Resolves #844

@jgebal jgebal closed this in #846 Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.