Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude / join_by on collections #912

Closed
jgebal opened this issue May 3, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@jgebal
Copy link
Member

commented May 3, 2019

When using exclude / include / join_by with collections, we are forced to use syntax:
'object_type_name/attribute' for those features.

As far as I remember it used to work differently and you only needed to use attribute name.

@lwasylow

This comment has been minimized.

Copy link
Member

commented May 3, 2019

But what would happen if we have an attribute of collection and then column with same name. The access by path for me seems natural and remove any ambiguity from names.

@jgebal

This comment has been minimized.

Copy link
Member Author

commented May 3, 2019

Thisvis for anydata.convertCollection.
When comparing two collections directly

@lwasylow

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Ok so anydata collection compare? I think issue lies in how anytype get type resolve collection. I believe it return name of itself need to verify that

@lwasylow

This comment has been minimized.

Copy link
Member

commented May 8, 2019

I can change it to use attribute base syntax.

The more challenging is the displaying the results.
This still uses old XML query type which read from xml generated so it contains the <TEST_DUMMY_OBJECT>.
My suggestion would be the leave a display to contain datytype name.

@lwasylow lwasylow self-assigned this May 9, 2019

@lwasylow lwasylow added the bug label May 9, 2019

@jgebal jgebal closed this in #923 Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.