Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricted columns in cursor compare #997

Closed
jgebal opened this issue Sep 22, 2019 · 0 comments · Fixed by #999
Assignees
Labels
bug
Milestone

Comments

@jgebal
Copy link
Member

@jgebal jgebal commented Sep 22, 2019

Describe the bug
Due to the nature of cursor comparison implementation, when comparing cursor containing one of column names:

  • ITEM_DATA
  • DATA_ID
  • ITEM_NO
  • DUP_NO
  • POSITION

The cursor comparison fails.

Provide version info
utPLSQL v3.1.8

To Reproduce
This can be observed on 3.1.8 with following block:

set serverout on
declare
  l_actual   sys_refcursor;
  l_expected sys_refcursor;
begin
  open l_actual   for select * from all_arguments where rownum = 1;
  open l_expected for select * from all_arguments where rownum = 1;
  ut.expect(l_actual).to_equal(l_expected);
end;
/

Expected behavior

utPLSQL should not prevent column names that are commonly used / possible to use.

One idea would be to use quoted and more unusual names for internal columns in cursor compare: "UT3$_Item#Data"

@jgebal jgebal added the bug label Sep 22, 2019
@jgebal jgebal self-assigned this Sep 22, 2019
jgebal added a commit that referenced this issue Sep 22, 2019
Columns:
 - ITEM_DATA
 - DATA_ID
 - ITEM_NO
 - DUP_NO
 - POSITION
Can now be safely used in cursors.
Resolves #997

Added delete on DIFF temp tables after cursor / object compare.
Resolves #998
jgebal added a commit that referenced this issue Sep 22, 2019
Columns:
 - ITEM_DATA
 - DATA_ID
 - ITEM_NO
 - DUP_NO
 - POSITION
Can now be safely used in cursors.
Resolves #997

Added delete on DIFF temp tables after cursor / object compare.
Resolves #998
@jgebal jgebal added this to the 3.1.9 milestone Sep 22, 2019
@jgebal jgebal closed this in #999 Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.