Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve coverage source query #981

Merged
merged 4 commits into from Jul 18, 2019

Conversation

@jgebal
Copy link
Member

commented Jul 17, 2019

Resolves #970

@rafael-trevisan - Will you be able to apply the changed package body on your DB, that was causing problems and confirm that it is working as expected?

This PR includes a different solution to the one your DBA has applied but it should also work fine.
The changed query syntax also applies some readability improvements to the code.

@jgebal jgebal added this to the v3.1.8 milestone Jul 17, 2019

@jgebal jgebal requested review from lwasylow and PhilippSalvisberg Jul 17, 2019

@rafael-trevisan

This comment has been minimized.

Copy link

commented Jul 17, 2019

Hi @jgebal, I confirm the change that @fabiopan has done is already in our DB and works beautifully. We've been generating the Coverage Report since the last couple days without any problem and its line number is accurate.

We did some improvement in the original workaround, so the version @fabiopan has posted is the lastest one.

@PhilippSalvisberg

This comment has been minimized.

Copy link
Member

commented Jul 18, 2019

The code is much more readable due to the code templates. And the query does not need subqueries anymore. That’s good. However, the optimizer has still the freedom to completely rewrite the statement. If this results in a bad plan (for all/dba_source access) then further named subqueries to isolate all/dba_source access with a no_merge or materialize hint might help. I’d go with this change “as is” now.

@PhilippSalvisberg PhilippSalvisberg merged commit 0858701 into develop Jul 18, 2019

4 checks passed

SonarCloud Code Analysis Quality Gate passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on feature/improve_coverage_source_query at 95.054%
Details
@PhilippSalvisberg PhilippSalvisberg referenced this pull request Jul 18, 2019

@jgebal jgebal deleted the feature/improve_coverage_source_query branch Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.