Python 2.5: Undefine _POSIX_C_SOURCE on Lion to fix 8-byte strings from socket.inet_aton() #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
socket.inet_aton() in Python 2.5.6 was returning 8-byte strings when built with Pythonbrew on OS X 10.7.3. The 8-byte strings were a result of a broken type cast identified in: - http://bugs.python.org/issue767150 - http://bugs.python.org/issue1008086 Part of the problem was that autoconf was failing to pick up on C lib's inet_aton(), exposing the broken type cast mentioned in the bug reports above. I found an existing precedence for suppressing _POSIX_C_SOURCE on older Darwins, which, when extended to cover 10.7.3, magically makes this bug go away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
socket.inet_aton()in Python 2.5.6 was returning 8-byte strings when built with Pythonbrew on OS X 10.7.3. The 8-byte strings were a result of a broken type cast identified in:Part of the problem was that autoconf was failing to pick up on C lib's
inet_aton(), exposing the broken type cast mentioned in the bug reports above. I found an existing precedence for suppressing_POSIX_C_SOURCEon older Darwins, which, when extended to cover 10.7.3, magically makes this bug go away.