Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exec_prefix to wxsqlite3.pc #13

Merged
merged 1 commit into from Mar 28, 2017

Conversation

Projects
None yet
2 participants
@Strubbl
Copy link
Contributor

commented Mar 28, 2017

This fixes an error when being used by cmake's
PKG_CHECK_MODULES( LIBWXSQLITE3 wxsqlite3 ),
which is basically the following error:

$ pkg-config --libs wxsqlite3
Variable 'exec_prefix' not defined in '/usr/lib/pkgconfig/wxsqlite3.pc'
add exec_prefix to wxsqlite3.pc
This fixes an error when being used by cmake's
`PKG_CHECK_MODULES( LIBWXSQLITE3 wxsqlite3 )`,
which is basically the following error:

```
$ pkg-config --libs wxsqlite3
Variable 'exec_prefix' not defined in '/usr/lib/pkgconfig/wxsqlite3.pc'
```
@Strubbl

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2017

this issue has been introduced since version 3.5.1. That was the last version, which was working for me. See:

$ pkg-config --libs wxsqlite3
-lwxcode_gtk2u_wxsqlite3-3.0

and the cmake check worked back then, too:

-- Checking for module 'wxsqlite3'
--   Found wxsqlite3, version 3.5.1
@Strubbl

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2017

documentation for exec_prefix can be found here: https://autotools.io/pkgconfig/file-format.html

@utelle utelle merged commit b30fd14 into utelle:master Mar 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@utelle

This comment has been minimized.

Copy link
Owner

commented Mar 28, 2017

Thanks for reporting this bug and providing a fix for it.

@Strubbl

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2017

Thanks for the fast response 👍
May i ask you to release a new minor version? This would fix the build of guayadeque in Archlinux

@Strubbl Strubbl deleted the Strubbl:exec_prefix-wxsqlite3.pc branch Mar 28, 2017

@utelle

This comment has been minimized.

Copy link
Owner

commented Mar 29, 2017

I'd like to wait a few more days before making a new release. On March 20 the first beta version of the upcoming SQLite version 3.18.0 was published, together with the announcement that a stable release would follow in about 2 weeks. And I would like to bundle the new SQLite version with the next release of wxSQLite3.

@Strubbl

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2017

Okay, no problem. I understand that.
I am looking forward for the next release.

@utelle

This comment has been minimized.

Copy link
Owner

commented Mar 31, 2017

Release of version 3.5.3 done today.

@Strubbl

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2017

thanks a lot. guayadeque build is again happy now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.