MCP Lifecycle fixes #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a comprehensive solution for managing server lifecycle with stdio transport: 1. StatePersistence: A new utility that maintains state across reconnections 2. MCP Protocol Synchronization: Properly tracks initialize/initialized handshake 3. Request Gating: Blocks requests during initialization to prevent partial responses This implementation solves issues with reconnection state loss, improves server restart handling, and ensures consistent responses during background initialization. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Resolves typecheck errors by fixing circular dependencies in imports: - Added explicit imports of get_nixos_context from server.py - Updated test files to import functions from correct modules - Fixed incorrect imports in MCP tool modules 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Removed unused imports (Union, get_context_or_fallback) from home_manager_tools.py and nixos_tools.py - Fixed circular dependencies by using importlib dynamic imports - Updated tests to use importlib mocking instead of patch(get_context_or_fallback) - Fixed flake8 linting errors - All tests now pass (350 passed, 3 skipped) - No typechecking errors 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
- Coverage 71.10% 68.94% -2.16%
==========================================
Files 32 33 +1
Lines 4329 4663 +334
==========================================
+ Hits 3078 3215 +137
- Misses 1251 1448 +197 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Modifies lint command to automatically format code with Black when running locally - Preserves lint-check behavior in CI environments for error detection - Detects CI environments using both CI and GITHUB_ACTIONS environment variables - Maintains Flake8 linter behavior in all environments 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add branch management documentation to CLAUDE.md - Remove trailing whitespace in test files - Maintain consistent indentation across test modules 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.