Improve the grammar error handling #874
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grammar constructors have now pretty large number of exceptions on which they panic. Some of them are even not documented in the doc string of the functions, maybe because even llama.cpp does not mention them.
For example, when the
grammar_strdoes not includegrammar_root, upon callinggrammar_lazyit just throwswhich is terrible for figuring out what is wrong (ive been there).
This PR fixes this, adding
GrammarErrorand sanitizing the inputs togrammarandgrammar_lazyfunctions.The change is however breaking as we need a way to propagate the errors - the output type thus moved from
Option<LlamaSampler>toResult<LlamaSampler, GrammarError>.