Skip to content

Commits

Permalink
master
Switch branches/tags

Name already in use

A tag already exists with the provided branch name. Many Git commands accept both tag and branch names, so creating this branch may cause unexpected behavior. Are you sure you want to create this branch?

Commits on Sep 20, 2022

  1. Merge pull request #47 from r7kamura/feature/url

    Fix incorrect documentation URLs when using `rubocop --show-docs-url`
    utkarsh2102 committed Sep 20, 2022
    Copy the full SHA
    275fd81 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Copy the full SHA
    0e4fd3b View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. Cut v0.5.2 release

    Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
    utkarsh2102 committed Aug 9, 2022
    Copy the full SHA
    fe87c12 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. Merge pull request #46 from koic/drop_ruby_25_runtime_support

    Drop Ruby 2.5 runtime support
    koic committed Aug 5, 2022
    Copy the full SHA
    7b18fd6 View commit details
    Browse the repository at this point in the history
  2. Drop Ruby 2.5 runtime support

    Follow rubocop/rubocop#10577.
    
    This PR drops Ruby 2.5 runtime support and fixes the following build error.
    https://github.com/utkarsh2102/rubocop-packaging/runs/7688082957
    koic committed Aug 5, 2022
    Copy the full SHA
    e342661 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #43 from marcotc/compatibility-with-rubocop-1.33

    Fix compatibility with Rubocop 1.33.0
    koic committed Aug 5, 2022
    Copy the full SHA
    0122e47 View commit details
    Browse the repository at this point in the history
  4. Suppress RuboCop offenses

    This commit suppresses the following RuboCop offenses.
    
    ```console
    % bundle exec rubocop
    (snip)
    
    spec/rubocop/cop/packaging/bundler_setup_in_tests_spec.rb:18:25: C:
    [Correctable] Style/EmptyHeredoc: Use an empty string literal instead of
    heredoc.
          expect_correction(<<~RUBY)
                            ^^^^^^^
    spec/rubocop/cop/packaging/bundler_setup_in_tests_spec.rb:33:25: C:
    [Correctable] Style/EmptyHeredoc: Use an empty string literal instead of
    heredoc.
          expect_correction(<<~RUBY)
                            ^^^^^^^
    spec/rubocop/cop/packaging/gemspec_git_spec.rb:82:24: C: [Correctable]
    Style/EmptyHeredoc: Use an empty string literal instead of heredoc.
        expect_no_offenses(<<~RUBY)
                           ^^^^^^^
    
    21 files inspected, 3 offenses detected, 3 offenses autocorrectable
    ```
    koic committed Aug 5, 2022
    Copy the full SHA
    d50e0c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. Fix lint issues

    marcotc committed Aug 4, 2022
    Copy the full SHA
    b4a5b2a View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    a9aedf8 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. Merge pull request #42 from petergoldstein/feature/migrate_ci_to_gith…

    …ub_actions
    
    Migrate CI to GitHub Actions
    utkarsh2102 committed Mar 17, 2022
    Copy the full SHA
    06ad865 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2022

  1. Copy the full SHA
    5716f31 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2021

  1. Merge pull request #41 from koic/remove_test_files

    Remove `spec.test_files` from `Packaging/GemspecGit`'s doc
    utkarsh2102 committed Sep 21, 2021
    Copy the full SHA
    d28d74e View commit details
    Browse the repository at this point in the history
  2. Remove spec.test_files from Packaging/GemspecGit's doc

    Follow up to rubocop/rubocop#10065 (comment).
    
    This PR removes `spec.test_files` from `Packaging/GemspecGit`'s doc.
    koic committed Sep 21, 2021
    Copy the full SHA
    db9f523 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #40 from koic/drop_ruby_24_support

    Drop Ruby 2.4 support
    utkarsh2102 committed Sep 21, 2021
    Copy the full SHA
    4cc22a3 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2021

  1. Drop Ruby 2.4 support

    Follow up to 6972a97
    and rubocop/rubocop#9648.
    koic committed Sep 18, 2021
    Copy the full SHA
    367278e View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2020

  1. Test against ruby3.0 \o/

    I am so excited, letz see how it goes! ^.^
    
    Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
    utkarsh2102 committed Dec 31, 2020
    Copy the full SHA
    bb1d525 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2020

  1. Set SuggestExtensions to false in .rubocop.yml

    Yeah, the extra "tip" is somewhat annoying at
    the moment. Maybe take a raincheck on this!?
    
    Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
    utkarsh2102 committed Dec 8, 2020
    Copy the full SHA
    9eeb5a8 View commit details
    Browse the repository at this point in the history
  2. Rename ExcludedMethods to IgnoredMethods

    Fixes the warning: obsolete parameter ExcludedMethods
    (for Metrics/BlockLength) found in .rubocop.yml
    `ExcludedMethods` has been renamed to `IgnoredMethods`.
    
    Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
    utkarsh2102 committed Dec 8, 2020
    Copy the full SHA
    9d4866c View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2020

  1. Merge pull request #34 from aryan1101/patch-1

    Fix compatibility spelling
    utkarsh2102 committed Oct 29, 2020
    Copy the full SHA
    1fe35a1 View commit details
    Browse the repository at this point in the history
  2. Fix compatibility spelling

    s/compatibility/compatibility/g
    aryan1101 committed Oct 29, 2020
    Copy the full SHA
    48514a3 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. Cut v0.5.1 release

    Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
    utkarsh2102 committed Oct 22, 2020
    Copy the full SHA
    ad12303 View commit details
    Browse the repository at this point in the history
  2. Remove redundant lines from .rubocop.yml

    Since all the cops are enabled by default, it
    doesn't make sense to explicitly set the
    "Enabled" field to "true". It's obvious that it is.
    
    Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
    utkarsh2102 committed Oct 22, 2020
    Copy the full SHA
    94688ab View commit details
    Browse the repository at this point in the history
  3. Run tests against ruby-head on CI

    Also allow it to fail since it's a wild
    playground of new features.
    
    Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
    utkarsh2102 committed Oct 22, 2020
    Copy the full SHA
    0c03361 View commit details
    Browse the repository at this point in the history
  4. Bump ruby2.7 pipeline to 2.7.2

    Now that ruby2.7.2 is out, let's use that
    rather than ruby2.7.1.
    
    Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
    utkarsh2102 committed Oct 22, 2020
    Copy the full SHA
    b82934c View commit details
    Browse the repository at this point in the history
  5. Merge pull request #33 from jasl/loosen-rubocop-requirement

    Loosen requirement of RuboCop
    utkarsh2102 committed Oct 22, 2020
    Copy the full SHA
    8756f99 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2020

  1. Loosen requirement of Rubocop

    jasl committed Oct 21, 2020
    Copy the full SHA
    26d7cc6 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2020

  1. Merge pull request #32 from koic/fix_html_id_attribute_in_cop_packagi…

    …ng_adoc
    
    Fix HTML id attribute in cops_packaging.adoc
    utkarsh2102 committed Oct 20, 2020
    Copy the full SHA
    f262d22 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2020

  1. Fix HTML id attribute in cops_packaging.adoc

    This PR fixes the following HTML id attribute in cops_packaging.adoc.
    
    ```console
    % git grep require-relative-hardcoding-lib-rationale
    docs/modules/ROOT/pages/cops_packaging.adoc:=== Rationale
    [[require-relative-hardcoding-lib-rationale]]
    docs/modules/ROOT/pages/cops_packaging.adoc:=== Examples
    [[require-relative-hardcoding-lib-rationale]]
    ```
    
    It will suppress the following warning that generates docs.rubocop.org.
    
    ```console
    $ cd docs.rubocop.org
    $ antora --pull antora-playbook.yml
    (snip)
    
    asciidoctor: WARNING: cops_packaging.adoc: line 205: id assigned to
    section already in use: require-relative-hardcoding-lib-rationale
    ```
    koic committed Oct 19, 2020
    Copy the full SHA
    6c20312 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2020

  1. Fix RequireRelativeHardcodingLib examples

    This is based on the comment and the discussion
    of #rubocop/rubocop/issues/8748#issuecomment-699478216
    
    Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
    utkarsh2102 committed Sep 26, 2020
    Copy the full SHA
    0ff30a3 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. Remove obsolete line in config/default.yml

    Unfortunately, I missed this line while fixing
    the description of the cops. Sigh.
    
    Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
    utkarsh2102 committed Sep 23, 2020
    Copy the full SHA
    a9925e7 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2020

  1. Cut v0.5.0 release

    Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
    utkarsh2102 committed Sep 19, 2020
    Copy the full SHA
    d27685c View commit details
    Browse the repository at this point in the history
  2. Disable Lint/InterpolationCheck for mocked tests

    Since the tests are mocked, disable Lint/InterpolationCheck
    because their autocorrect breaks the tests (since they're
    mocked :)).
    
    Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
    utkarsh2102 authored and terceiro committed Sep 19, 2020
    Copy the full SHA
    f0f4029 View commit details
    Browse the repository at this point in the history
  3. Add tests to check interpolated require calls

    Add tests to check if the interpolated require calls
    are correctly being caught by the RequireHardcodingLib
    cop and that the autocorrect for it is working fine
    as well.
    
    Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
    utkarsh2102 authored and terceiro committed Sep 19, 2020
    Copy the full SHA
    562193e View commit details
    Browse the repository at this point in the history
  4. Add AST pattern to catch interpolated require calls

    Style/StringConcatenation's autocorrect hinders with the
    existing AST pattern of RequireHardcodingLib to catch
    offensive require calls.
    
    So add the interpolated AST to catch those lines as well.
    
    Fixes: #30
    
    Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
    utkarsh2102 authored and terceiro committed Sep 19, 2020
    Copy the full SHA
    f451b88 View commit details
    Browse the repository at this point in the history
  5. Improve offense messages

    Make it a bit more clearer as to what's
    problematic and what to do intead of those
    lines of code.
    
    Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
    utkarsh2102 committed Sep 19, 2020
    Copy the full SHA
    ce31001 View commit details
    Browse the repository at this point in the history
Older