Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #2

Merged
merged 6 commits into from Jun 17, 2020
Merged

Update documentation #2

merged 6 commits into from Jun 17, 2020

Conversation

utkarsh2102
Copy link
Owner

@utkarsh2102 utkarsh2102 commented Jun 15, 2020

Hi,

This PR documents the entire source code and also adds the docs/ directory.
For a visual representation of the change, you can check the documentation branch.

The source code is now 100% documented:

➜  rubocop-packaging git:(master) rake generate_cops_documentation
Files:           1
Modules:         3 (    0 undocumented)
Classes:         1 (    0 undocumented)
Constants:       1 (    0 undocumented)
Attributes:      0 (    0 undocumented)
Methods:         2 (    0 undocumented)
 100.00% documented

Please don't squash the commits as they each represent a separate change.

@deivid-rodriguez
Copy link
Collaborator

I'll review this later. You can disable "Squash merging" in the repo settings if you want :)

@utkarsh2102 utkarsh2102 added the documentation Improvements or additions to documentation label Jun 15, 2020
Copy link
Collaborator

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These docs are super-neat @utkarsh2102. Nice job 👍. I added some comments, but really minor.

README.md Outdated Show resolved Hide resolved
lib/rubocop/cop/packaging/gemspec_git.rb Outdated Show resolved Hide resolved
lib/rubocop/cop/packaging/gemspec_git.rb Outdated Show resolved Hide resolved
lib/rubocop/cop/packaging/gemspec_git.rb Outdated Show resolved Hide resolved
Copy link
Collaborator

@terceiro terceiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall I think it looks good, but it seems that the same documentation bits are duplicated in two places.

README.md Outdated Show resolved Hide resolved
lib/rubocop/cop/packaging/gemspec_git.rb Show resolved Hide resolved
utkarsh2102 and others added 2 commits June 16, 2020 16:32
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
This basically does the 3 following things:
- Adds `# :nodoc:` for the three modules that doesn't need any
  documentation. Thanks to Antonio for this suggestion.
- It replaces the link to `cop.rb` file as a permalink so it
  doesn't get broken over time. Thanks to David for this suggestion.
- Paraphrases a line in README.md so as to *not* use the word "cop"
  as readers might not be familiar with the term.

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
@utkarsh2102
Copy link
Owner Author

Thanks, @deivid-rodriguez and @terceiro!
I've added also the suggestions in the latest commit (and wrote a slightly detailed commit message for the explanation).
It's up for your review again; feel free to merge if everything looks good to you :)

@utkarsh2102
Copy link
Owner Author

Thanks, both.
Merging..

@utkarsh2102 utkarsh2102 merged commit 4b553b4 into master Jun 17, 2020
@utkarsh2102 utkarsh2102 deleted the documentation branch June 17, 2020 15:31
@utkarsh2102 utkarsh2102 removed the documentation Improvements or additions to documentation label Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants