Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CopsDocumentationGenerator to generate documentation #7

Merged
merged 3 commits into from Aug 5, 2020

Conversation

utkarsh2102
Copy link
Owner

This shall now work fine with the next release of RuboCop.
(and once the new version is released, I'll add back the task in the list of default tasks.)

Need: With the new auto-correct API, this task failed to continue working as it should.
There had to be some sort of refactoring (as mentioned here). And so we follow rubocop/rubocop#8369! 馃帀

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>

@utkarsh2102 utkarsh2102 added bug Something isn't working documentation Improvements or additions to documentation don't merge Don't merge this PR until this label is removed labels Jul 29, 2020
Thanks to Benjamin for implementing this class.
(will be available in the next release after v0.88.0)

Follow rubocop/rubocop#8369

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
Previously, it was removed because the new auto-corrector
API broke that Rake task and was making the CI red.

Now, that the task has been refactored and is fit to go
live again, adding `generate_cops_documentation` back as
a default task should be a good idea.

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
Prefer string interpolation to string concatenation.

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
@utkarsh2102 utkarsh2102 removed the don't merge Don't merge this PR until this label is removed label Aug 5, 2020
Copy link
Collaborator

@terceiro terceiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utkarsh2102 utkarsh2102 merged commit 189b646 into master Aug 5, 2020
@utkarsh2102 utkarsh2102 deleted the fix-cops_doc-task branch August 5, 2020 23:54
@utkarsh2102 utkarsh2102 removed bug Something isn't working documentation Improvements or additions to documentation labels Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants