feat-6861-46elks-messaging-adapter #54
Conversation
|
@wess Thank you for approving my PR . Just wanted to ask when it will be merged in the codebase. |
|
Discord Handle :- dhairya7#5015 |
|
Hello @DhairyaMajmudar Thank you for your contribution to Hacktoberfest 2023! We've noticed that your PR is still pending and requires some updates based on our engineering team's feedback. We would love to see your PR successfully merged and send you the Appwrite swag as a token of appreciation. To remain eligible for the swag, please address the failed checks and update your PR and also show a screenshot of your tests passing by Friday, November 17th. If the PR isn't updated by then, we will unfortunately have to close it due to the end of the Hacktoberfest event. Looking forward to your updates and thank you! |
|
Hey @wess I was trying to fix the failed lint and e2e checks but didn't got the issues , can pls. point to the issue failing these checks |
There was a problem hiding this comment.
Rest looks fine although the lint might be complaining about the casing in the file name.
Would Recommend to rename the file like (FortySixelks.php)
To Fix the remaining lint errors:
run composer format
Tests are failing and its not related to your issue.
Although I would recommend to add a test file for this adaptor as well.
It's simple and you can refer to one of the adaptors here
Adding Suggestions Co-authored-by: Bishwajeet Parhi <62933155+2002Bishwajeet@users.noreply.github.com>
|
@2002Bishwajeet I have committed suggested changes and also added the test files for testing Pls. review this and merge my PR
|
|
@wess @2002Bishwajeet pls. review my pr and merge it . |
|
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
|
Thank you @gewenyu99 here is my discord username |
|
We'll contact again when we reach out. Adding your name to the list! Appreciate your immense patience with us. |
What does this PR do?
Integration of 46elks SMS to the Appwrite messaging system
Test Plan
Added a new 46elk.php file in
src/Utpoia/Messaging/Adapters/SMSfolder path . In this file I have added the PHP code for the integration of 46elks SMS with the Appwrite messaging system.Related PRs and Issues
Closes appwrite/appwrite#6861
Have you read the Contributing Guidelines on issues?
YES