Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for netapp storage grid adapter #96

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pratiksardar
Copy link

No description provided.

@pratiksardar
Copy link
Author

Issue No: appwrite/appwrite#6414

@vermakhushboo
Copy link
Member

@pratiksardar thanks for creating this pull request. 😄 Can you please fix the linter by running composer format, and write the tests and post a screenshot of the Netapp tests passing locally? Once you do that, I'll start reviewing your PR. I see that there are more methods that you need to implement. Also, at some places you need to change Alibaba Cloud to Netapp. Please make the required changes.

@gewenyu99
Copy link

Hey,

Due to time constraints, I'm going to mark this PR hacktoberfest-accepted for now so you get DO's Hacktoberfest rewards. We'll continue to work with you on this issue for review and merge.

When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag.

Thanks for helping us improve Appwrite!

@pratiksardar
Copy link
Author

@vermakhushboo I've incorporated the comments you have mentioned and the formatting has no issues and passes the linting.

@gewenyu99
Copy link

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

@pratiksardar
Copy link
Author

pratiksardar commented Apr 9, 2024

Hey My discord username is radarsardar / radarsardar#1578

@gewenyu99
Copy link

@pratiksardar We'll get to you soon. Collecting everyone's contact rn across many PRs :)

@gewenyu99
Copy link

Send out a friend request @pratiksardar :)

@pratiksardar
Copy link
Author

pratiksardar commented Apr 29, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants