Morphological image processing#209
Merged
Merged
Conversation
5600f99 to
bd1d037
Compare
bd1d037 to
4c8046e
Compare
smikitky
requested changes
Dec 6, 2021
Member
smikitky
left a comment
There was a problem hiding this comment.
erosion/dilatation用のダイアログのデザインを調整しました。
- CIRCUSにはダークモードがあるので、決め打ちで色を書くのはできるだけ避けてください。どうしてもやる場合はダークモードとライトモードの両方でデザインを確認してください。
- classnames を使えるようになってください。
- いまどき float を使ってグリッドをレイアウトするのは止めましょう…。
- コンポーネントへの型付けのしかたを他のコードベースと統一してください。
以下の修正をお願いします。
- structure に型名を付けてください。
- erosion / dilatation のシグネチャは共通だと思うのでそれについても型を付けて、同じシグネチャで扱えるコードだというのを明示しましょう。
- performLabelCreatingVoxelProcessing.ts に、大部分が同じような長いコードのコピペが現れています。似たような処理の流れを可能な限り統一的に扱うために書いたコードなのに、それ自体をコピペで増やしていたのでは本末転倒です。シグネチャを工夫したら統一できませんか?
smikitky
requested changes
Dec 7, 2021
| nSlices: number; | ||
| }; | ||
|
|
||
| export type BasicMorphologicalOperations = ( |
6d9adea to
5230272
Compare
smikitky
approved these changes
Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.