Label duplications, boolean operations for VoxelClouds#281
Merged
Conversation
smikitky
changed the title
smikitky
approved these changes
Jun 16, 2022
Member
smikitky
left a comment
smikitky
left a comment
There was a problem hiding this comment.
デザインの変更とかが難しくなるのでCSSルールとかをコピペするのは止めましょう。面倒でもちゃんと共通のコンポーネントに抽出してください。
smikitky
reviewed
Jun 16, 2022
Comment on lines
-27
to
-34
| useEffect(() => { | ||
| if (value.targetLabelIndex < 0) { | ||
| onChange({ | ||
| ...value, | ||
| targetLabelIndex: targetIndex[initialLabelIndex] | ||
| }); | ||
| } | ||
| }, []); |
Member
There was a problem hiding this comment.
こういう dependency array の正しさを無視した useEffect は危険です。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.