Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new
doodHostWorkingDirectoryoption topluginJobRunner.When using CIRCUS with the DooD (docker-outside-of-docker) approach, the main CIRCUS container and a plug-in container will be created like this:
CIRCUS running in a container must ask the host to create the plug-in container, but it does not know the path of the parent host directory (i.e., "c:\circus-data\cs-tmp"). This option is used to set this path. The path must correspond to the
workingDirectoryoption.To use this, add something like the following in circus config file (the actual value will depend on how you mounted volumes while creating the main CIRCUS container):