#26 getFee() calculates with floating value

[Dawn-githup]

[Dawn-githup]

txid：https://mempool.space/testnet/tx/c011d6f5ce04497cbb1365dac4f4bce50ffd71bd7b4710520e13ad738d3533be

Verification scenario：

Transfer fixed UTXO, sum(ins) = sum(outs)

fee is calculated as a floating value

error:

Error:BtcAssetSAPIreturned an error:.(-26)min relay fee not met, 208 < 209

[ShookLyngs]

This issue was supposed to be fixed at: commit #9482f6. What I changed in the commit was that I added a additional inputs.length to the sum of the transaction weight when calculating:

-const weight = weightWithoutWitness * 3 + weightWithWitness;
+const weight = weightWithoutWitness * 3 + weightWithWitness + inputsLength;

Although I'm still not 100% sure that the issue is fixed, it should make a difference as the fee is definitely enough if each input's witness can only be 1 byte smaller than it should be (the stats says it usually needs 0.5 byte more, so adding 1 byte should be reasonable). Can you guys review the fee estimation code with me?

[ShookLyngs]

We have not received any reports about the issue since the previous comment.
I think it's safe to say the issue is resolved, therefore I'm closing it.