From 3610f7c1b37753377196dee4b8c380cc97615e49 Mon Sep 17 00:00:00 2001
From: Shook <shooklyngs@gmail.com>
Date: Tue, 14 May 2024 18:30:03 +0800
Subject: [PATCH 1/3] refactor: improve readability of "if statement" in
 service requests

---
 packages/service/src/service/base.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/service/src/service/base.ts b/packages/service/src/service/base.ts
index b8bab5cd..3007cc88 100644
--- a/packages/service/src/service/base.ts
+++ b/packages/service/src/service/base.ts
@@ -96,7 +96,7 @@ export class BtcAssetsApiBase implements BaseApis {
     if (status !== 200 && status !== 404 && !allow404) {
       throw BtcAssetsApiError.withComment(ErrorCodes.ASSETS_API_RESPONSE_ERROR, comment, context);
     }
-    if (status !== 200) {
+    if (status === 404 && allow404) {
       return undefined as T;
     }
 

From 4c68107d6329a804aaab8b2abb9eb11594cd93f0 Mon Sep 17 00:00:00 2001
From: Shook <shooklyngs@gmail.com>
Date: Tue, 14 May 2024 18:33:24 +0800
Subject: [PATCH 2/3] refactor: improve readability of the service fetch params

---
 packages/service/src/service/base.ts | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/packages/service/src/service/base.ts b/packages/service/src/service/base.ts
index 3007cc88..5abf1453 100644
--- a/packages/service/src/service/base.ts
+++ b/packages/service/src/service/base.ts
@@ -32,15 +32,14 @@ export class BtcAssetsApiBase implements BaseApis {
       await this.init();
     }
 
-    const packedParams = params ? '?' + new URLSearchParams(pickBy(params, (val) => val !== undefined)).toString() : '';
-    const withOriginHeaders = this.origin ? { origin: this.origin } : undefined;
-    const withAuthHeaders = requireToken && this.token ? { Authorization: `Bearer ${this.token}` } : undefined;
+    const pickedParams = pickBy(params, (val) => val !== undefined);
+    const packedParams = params ? '?' + new URLSearchParams(pickedParams).toString() : '';
     const url = `${this.url}${route}${packedParams}`;
     const res = await fetch(url, {
       method,
       headers: {
-        ...withOriginHeaders,
-        ...withAuthHeaders,
+        authorization: this.token ? `Bearer ${this.token}` : undefined,
+        origin: this.origin,
         ...headers,
       },
       ...otherOptions,

From a3e4a819e2591a72dc7612cad25bf382ff33d5bc Mon Sep 17 00:00:00 2001
From: Shook <shooklyngs@gmail.com>
Date: Tue, 14 May 2024 19:17:10 +0800
Subject: [PATCH 3/3] chore: set service tests timeout to 20 sec

---
 packages/service/vitest.config.mts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/service/vitest.config.mts b/packages/service/vitest.config.mts
index 2d9b2ac0..69b2c0b4 100644
--- a/packages/service/vitest.config.mts
+++ b/packages/service/vitest.config.mts
@@ -3,7 +3,7 @@ import { defineConfig } from 'vitest/config';
 export default defineConfig({
   test: {
     watch: false,
-    testTimeout: 15000,
+    testTimeout: 20000,
     reporters: ['verbose'],
     exclude: ['lib', 'node_modules'],
   },