Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check more features in no-std #528

Merged
merged 4 commits into from Aug 16, 2021
Merged

check more features in no-std #528

merged 4 commits into from Aug 16, 2021

Conversation

KodrAus
Copy link
Member

@KodrAus KodrAus commented Aug 16, 2021

For #469

This checks a few more features against a proper no-std target, to make sure we're not accidentally pulling in std.

It doesn't currently test v4, because it needs an ambient source of randomness. I think that's possible to do with getrandom, but we also have other methods for constructing a random UUID without needing the v4 feature explicitly.

@KodrAus
Copy link
Member Author

@KodrAus KodrAus commented Aug 16, 2021

I've replaced our usage of std::sync::atomic with the atomic crate. It looks like it will panic at runtime on platforms that don't support atomic operations. This might not be ideal long-term, but lets us build the v1 feature without needing to complicate our crate features before the has_atomic cfg is stabilized.

@KodrAus KodrAus merged commit e51f80a into main Aug 16, 2021
19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the ci/more-embedded branch Aug 16, 2021
@KodrAus KodrAus mentioned this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant