Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove winapi support in favor of examples #548

Merged
merged 3 commits into from Nov 1, 2021

Conversation

KodrAus
Copy link
Member

@KodrAus KodrAus commented Nov 1, 2021

Closes #537

Instead of worrying about a conversion library right now this just removes the winapi support and adds some examples of creating UUIDs from GUIDs. We can't be certain that all GUIDs can be converted into UUIDs without flipping fields so our to_guid and from_guid methods don't seem like they could ever be guaranteed to always be correct.

@KodrAus
Copy link
Member Author

KodrAus commented Nov 1, 2021

I've also fixed up my broken changes to the v1::Context so it goes back to its old implementation of always incrementing the counter, but will wrap on the max value representable by the UUID, not the max value in a usize.

@KodrAus KodrAus merged commit 2925da3 into uuid-rs:main Nov 1, 2021
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move winapi support into a new unstable crate
1 participant