Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional arbitrary impl #550

Merged
merged 4 commits into from Nov 1, 2021
Merged

Conversation

KodrAus
Copy link
Member

@KodrAus KodrAus commented Nov 1, 2021

Closes #514

Adds an optional implementation of the stable Arbitrary trait to Uuid so it can be used for fuzzing.

We always give you a valid V4 UUID from the input, unless there aren't enough bytes.

I've also streamlined some of our templates a bit, since I find myself removing most of the scaffolding when writing PRs and issues.

Copy link
Member

@kinggoesgaming kinggoesgaming left a comment

Other than removing the mailing list (since you touched that file), everything looks good

CONTRIBUTING.md Outdated Show resolved Hide resolved
@KodrAus
Copy link
Member Author

@KodrAus KodrAus commented Nov 1, 2021

Thanks for the review @kinggoesgaming! I've been hammering at these last mile stabilization tasks so have made a huge pile of basically unreviewable changes. I was going to open a PR that prepares for our 1.0.0-alpha release and lists everything out so we can review the whole end result.

@kinggoesgaming
Copy link
Member

@kinggoesgaming kinggoesgaming commented Nov 1, 2021

Should be good!

@kinggoesgaming kinggoesgaming merged commit 7b55e32 into uuid-rs:main Nov 1, 2021
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants